-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: sync cache only on compare returns true #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 062de50:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels good to me, but this change assumes that stateRef.current.data
equals to the current cache. I'm not sure if there's any case that it will break.
Hi team, thanks for this quick PR :) |
db4b730
to
1d26c95
Compare
rebased to resolve the conflicts |
I'd expect it won't be a problem with dequal since it supports various primtive data types. I feel it's ok to ship in a patch version and we can wait if there's any issue reports form community? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna ship this once all tests have passed. Thank you!
Thank you all! |
#1056 |
fixes #906